From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B77A71FA12 for ; Mon, 25 Jan 2021 01:18:57 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 2/5] lei q: drop "oid" output format Date: Sun, 24 Jan 2021 17:18:54 -0800 Message-Id: <20210125011857.563-3-e@80x24.org> In-Reply-To: <20210125011857.563-1-e@80x24.org> References: <20210125011857.563-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: The default deduplication command-line arguments would be non-sensical for such an option and probably confusing. It doesn't seem worth the code to support OID-only output when it's easy enough to use one of the JSON formats to extract the same info. We also don't have OIDs if using remotes, and the to-be-implemented memoization will be optional. --- lib/PublicInbox/LEI.pm | 3 ++- lib/PublicInbox/LeiOverview.pm | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index 378113e8..09eac58c 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -200,7 +200,8 @@ my %OPTDESC = ( 'message/object output format' ], 'mark format|f=s' => $stdin_formats, 'forget format|f=s' => $stdin_formats, -'q format|f=s' => [ 'OUT|maildir|mboxrd|mboxcl2|mboxcl|html|oid|json', +'q format|f=s' => [ + 'OUT|maildir|mboxrd|mboxcl2|mboxcl|html|json|jsonl|concatjson', 'specify output format, default depends on --output'], 'ls-query format|f=s' => $ls_format, 'ls-external format|f=s' => $ls_format, diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm index 880c7acc..ea35871c 100644 --- a/lib/PublicInbox/LeiOverview.pm +++ b/lib/PublicInbox/LeiOverview.pm @@ -286,10 +286,6 @@ sub ovv_each_smsg_cb { # runs in wq worker usually $buf = ''; } } - } elsif ($self->{fmt} eq 'oid') { - sub { - my ($smsg, $mitem) = @_; - } } # else { ... }