* Re: [PATCH] inbox: do not vivify {-repo_objs} during cleanup
2021-09-29 0:14 14% ` [PATCH] inbox: do not vivify {-repo_objs} during cleanup Eric Wong
@ 2021-09-29 0:55 7% ` Kyle Meyer
0 siblings, 0 replies; 2+ results
From: Kyle Meyer @ 2021-09-29 0:55 UTC (permalink / raw)
To: Eric Wong; +Cc: meta
Eric Wong writes:
> Thanks, the following should fix it (though I suppose @INC paths
> should be cleaned in WWW):
> ------8<-----
> Subject: [PATCH] inbox: do not vivify {-repo_objs} during cleanup
Seems to do the trick. Thank you!
^ permalink raw reply [relevance 7%]
* [PATCH] inbox: do not vivify {-repo_objs} during cleanup
@ 2021-09-29 0:14 14% ` Eric Wong
2021-09-29 0:55 7% ` Kyle Meyer
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-09-29 0:14 UTC (permalink / raw)
To: Kyle Meyer; +Cc: meta
Kyle Meyer <kyle@kyleam.com> wrote:
> I've been noticing a good number of these error messages:
>
> E: BUG {try_gits} empty at /usr/local/share/perl/5.28.1/PublicInbox/SolverGit.pm line 80.
Thanks, the following should fix it (though I suppose @INC paths
should be cleaned in WWW):
------8<-----
Subject: [PATCH] inbox: do not vivify {-repo_objs} during cleanup
This caused config->repo_objs to not fill in {-repo_objs}
properly before starting solver.
Reported-by: Kyle Meyer <kyle@kyleam.com>
Link: https://public-inbox.org/meta/87o88cqobd.fsf@kyleam.com/
Fixes: 63d7b8ceee55a34 ("daemons: revamp periodic cleanup task")
---
lib/PublicInbox/Inbox.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index c525f4d1..95467d5a 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -30,7 +30,7 @@ sub do_cleanup {
my ($ibx) = @_;
my $live = git_cleanup($ibx);
$ibx->cleanup_shards and $live = 1;
- for my $git (@{$ibx->{-repo_objs}}) {
+ for my $git (@{$ibx->{-repo_objs} // []}) {
$live = 1 if $git->cleanup(1);
}
delete @$ibx{qw(over mm description cloneurl
^ permalink raw reply related [relevance 14%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-09-28 23:21 solver: 'BUG {try_gits} empty' error Kyle Meyer
2021-09-29 0:14 14% ` [PATCH] inbox: do not vivify {-repo_objs} during cleanup Eric Wong
2021-09-29 0:55 7% ` Kyle Meyer
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).