From: Eric Wong <e@80x24.org> To: Kyle Meyer <kyle@kyleam.com> Cc: meta@public-inbox.org Subject: [PATCH] inbox: do not vivify {-repo_objs} during cleanup Date: Wed, 29 Sep 2021 00:14:28 +0000 [thread overview] Message-ID: <20210929001428.GA28946@dcvr> (raw) In-Reply-To: <87o88cqobd.fsf@kyleam.com> Kyle Meyer <kyle@kyleam.com> wrote: > I've been noticing a good number of these error messages: > > E: BUG {try_gits} empty at /usr/local/share/perl/5.28.1/PublicInbox/SolverGit.pm line 80. Thanks, the following should fix it (though I suppose @INC paths should be cleaned in WWW): ------8<----- Subject: [PATCH] inbox: do not vivify {-repo_objs} during cleanup This caused config->repo_objs to not fill in {-repo_objs} properly before starting solver. Reported-by: Kyle Meyer <kyle@kyleam.com> Link: https://public-inbox.org/meta/87o88cqobd.fsf@kyleam.com/ Fixes: 63d7b8ceee55a34 ("daemons: revamp periodic cleanup task") --- lib/PublicInbox/Inbox.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm index c525f4d1..95467d5a 100644 --- a/lib/PublicInbox/Inbox.pm +++ b/lib/PublicInbox/Inbox.pm @@ -30,7 +30,7 @@ sub do_cleanup { my ($ibx) = @_; my $live = git_cleanup($ibx); $ibx->cleanup_shards and $live = 1; - for my $git (@{$ibx->{-repo_objs}}) { + for my $git (@{$ibx->{-repo_objs} // []}) { $live = 1 if $git->cleanup(1); } delete @$ibx{qw(over mm description cloneurl
next prev parent reply other threads:[~2021-09-29 0:14 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-28 23:21 solver: 'BUG {try_gits} empty' error Kyle Meyer 2021-09-29 0:14 ` Eric Wong [this message] 2021-09-29 0:55 ` [PATCH] inbox: do not vivify {-repo_objs} during cleanup Kyle Meyer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210929001428.GA28946@dcvr \ --to=e@80x24.org \ --cc=kyle@kyleam.com \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH] inbox: do not vivify {-repo_objs} during cleanup' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).