* [PATCH 2/3] http: log response_write errors
2020-01-09 11:14 6% [PATCH 0/3] improve error handling for rare cases Eric Wong
@ 2020-01-09 11:14 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-01-09 11:14 UTC (permalink / raw)
To: meta
Application-supplied callbacks may error out, try to log them
so the PSGI app developer can figure out what went wrong.
---
lib/PublicInbox/HTTP.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 1346901a..a6ec1d0d 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -174,7 +174,10 @@ sub app_dispatch {
response_write($self, $env, $res);
}
};
- $self->close if $@;
+ if ($@) {
+ err($self, "response_write error: $@");
+ $self->close;
+ }
}
sub response_header_write {
^ permalink raw reply related [relevance 7%]
* [PATCH 0/3] improve error handling for rare cases
@ 2020-01-09 11:14 6% Eric Wong
2020-01-09 11:14 7% ` [PATCH 2/3] http: log response_write errors Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-01-09 11:14 UTC (permalink / raw)
To: meta
I tend to configure high RLIMIT_NOFILE limits, and the default
/proc/sys/fs/epoll/max_user_watches is difficult to hit, so
I've never hit the errors these patches supposedly fix...
But, I've noticed there's a places were we could die() without
an eval{} to trap it. These patches fix some of those.
On a side note, we still lack sufficient testing for rare error
conditions. These errors are not easy to reproduce, especially
EPOLL_CTL_ADD failures.
Also, the IO::KQueue->EV_SET calls actually make calls to
kqueue(2) directly (working more like epoll_ctl), so those could
die() inside the emulated epoll_ctl... Another day
Eric Wong (3):
listener: EPOLL_CTL_ADD errors are non fatal
http: log response_write errors
qspawn: catch transient errors on pipe, EPOLL_CTL_ADD
lib/PublicInbox/HTTP.pm | 5 ++++-
lib/PublicInbox/Listener.pm | 3 ++-
lib/PublicInbox/Qspawn.pm | 29 ++++++++++++++++++-----------
3 files changed, 24 insertions(+), 13 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-01-09 11:14 6% [PATCH 0/3] improve error handling for rare cases Eric Wong
2020-01-09 11:14 7% ` [PATCH 2/3] http: log response_write errors Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).