From: Eric Wong <e@yhbt.net>
To: meta@public-inbox.org
Subject: [PATCH 2/3] http: log response_write errors
Date: Thu, 9 Jan 2020 11:14:51 +0000 [thread overview]
Message-ID: <20200109111452.14556-3-e@yhbt.net> (raw)
In-Reply-To: <20200109111452.14556-1-e@yhbt.net>
Application-supplied callbacks may error out, try to log them
so the PSGI app developer can figure out what went wrong.
---
lib/PublicInbox/HTTP.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 1346901a..a6ec1d0d 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -174,7 +174,10 @@ sub app_dispatch {
response_write($self, $env, $res);
}
};
- $self->close if $@;
+ if ($@) {
+ err($self, "response_write error: $@");
+ $self->close;
+ }
}
sub response_header_write {
next prev parent reply other threads:[~2020-01-09 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 11:14 [PATCH 0/3] improve error handling for rare cases Eric Wong
2020-01-09 11:14 ` [PATCH 1/3] listener: EPOLL_CTL_ADD errors are non fatal Eric Wong
2020-01-09 11:14 ` Eric Wong [this message]
2020-01-09 11:14 ` [PATCH 3/3] qspawn: catch transient errors on pipe, EPOLL_CTL_ADD Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109111452.14556-3-e@yhbt.net \
--to=e@yhbt.net \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).