* [PATCH 0/3] start removing Plack::Request from WWW
@ 2016-05-30 2:04 6% Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2016-05-30 2:04 UTC (permalink / raw)
To: meta
It's unnecessary overhead and parsing request bodies for
forms should not be done for our application.
In other words, workarounds like commit 311c2adc8c63
("git-http-backend: avoid Plack::Request parsing body")
should not be necessary.
Eric Wong (3):
git-http-backend: remove dependency on Plack::Request
www: remove gratuitous use of Plack::Request methods
www: remove a few more Plack::Request dependencies
lib/PublicInbox/Feed.pm | 18 +++++++++---------
lib/PublicInbox/GitHTTPBackend.pm | 26 +++++++++++++-------------
lib/PublicInbox/SearchView.pm | 14 +++++++-------
lib/PublicInbox/WWW.pm | 28 ++++++++++++++++++----------
t/git-http-backend.psgi | 6 ++----
t/git-http-backend.t | 2 +-
6 files changed, 50 insertions(+), 44 deletions(-)
^ permalink raw reply [relevance 6%]
* [PATCH 1/2] git-http-backend: avoid Plack::Request parsing body
2016-05-23 6:23 5% ` [PATCH 0/2] more git-http-backend cleanups Eric Wong
@ 2016-05-23 6:23 7% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2016-05-23 6:23 UTC (permalink / raw)
To: meta
Only check query parameters since there's no useful body
in there.
---
lib/PublicInbox/GitHTTPBackend.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 97834de..70990eb 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -42,7 +42,7 @@ sub r ($;$) {
sub serve {
my ($cgi, $git, $path) = @_;
- my $service = $cgi->param('service') || '';
+ my $service = $cgi->query_parameters->get('service') || '';
if ($service =~ /\Agit-\w+-pack\z/ || $path =~ /\Agit-\w+-pack\z/) {
my $ok = serve_smart($cgi, $git, $path);
return $ok if $ok;
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] more git-http-backend cleanups
@ 2016-05-23 6:23 5% ` Eric Wong
2016-05-23 6:23 7% ` [PATCH 1/2] git-http-backend: avoid Plack::Request parsing body Eric Wong
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2016-05-23 6:23 UTC (permalink / raw)
To: meta
git-http-backend (and all of our long-running processes) is
likely to encounter dropped connections. Ensure we release
resources properly when a client hits Ctrl-C or similar while
waiting on a slow git clone.
Eric Wong (2):
git-http-backend: avoid Plack::Request parsing body
git-http-backend: refactor to support cleanup
lib/PublicInbox/GitHTTPBackend.pm | 84 +++++++++++++++++++--------------------
lib/PublicInbox/HTTPD.pm | 5 +--
lib/PublicInbox/HTTPD/Async.pm | 23 ++++++-----
3 files changed, 56 insertions(+), 56 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-05-22 20:57 [PATCH 0/5] a few more HTTP-async-related simplifications Eric Wong
2016-05-23 6:23 5% ` [PATCH 0/2] more git-http-backend cleanups Eric Wong
2016-05-23 6:23 7% ` [PATCH 1/2] git-http-backend: avoid Plack::Request parsing body Eric Wong
2016-05-30 2:04 6% [PATCH 0/3] start removing Plack::Request from WWW Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).