user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] git-http-backend: avoid Plack::Request parsing body
Date: Mon, 23 May 2016 06:23:01 +0000	[thread overview]
Message-ID: <20160523062302.30946-2-e@80x24.org> (raw)
In-Reply-To: <20160523062302.30946-1-e@80x24.org>

Only check query parameters since there's no useful body
in there.
---
 lib/PublicInbox/GitHTTPBackend.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 97834de..70990eb 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -42,7 +42,7 @@ sub r ($;$) {
 sub serve {
 	my ($cgi, $git, $path) = @_;
 
-	my $service = $cgi->param('service') || '';
+	my $service = $cgi->query_parameters->get('service') || '';
 	if ($service =~ /\Agit-\w+-pack\z/ || $path =~ /\Agit-\w+-pack\z/) {
 		my $ok = serve_smart($cgi, $git, $path);
 		return $ok if $ok;

  reply	other threads:[~2016-05-23  6:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-22 20:57 [PATCH 0/5] a few more HTTP-async-related simplifications Eric Wong
2016-05-22 20:57 ` [PATCH 1/5] t/spawn.t: additional tests for popen_rd Eric Wong
2016-05-22 20:57 ` [PATCH 2/5] git-http-backend: remove process limit Eric Wong
2016-05-22 20:57 ` [PATCH 3/5] git-http-backend: simplify dumb serving Eric Wong
2016-05-22 20:57 ` [PATCH 4/5] http: rework async_pass support Eric Wong
2016-05-22 20:57 ` [PATCH 5/5] git-http-backend: switch to async_pass Eric Wong
2016-05-23  6:23 ` [PATCH 0/2] more git-http-backend cleanups Eric Wong
2016-05-23  6:23   ` Eric Wong [this message]
2016-05-23  6:23   ` [PATCH 2/2] git-http-backend: refactor to support cleanup Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160523062302.30946-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).