user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH] feed: fix "created" vs "updated" diff in topics
@ 2015-08-25  9:42  7% Eric Wong
  0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2015-08-25  9:42 UTC (permalink / raw)
  To: meta

This fixes a regression introduced in
commit 72c0f7c71ff28de9755dc4aee8b6ce6f0e4f2ed7
(feed: merge subjects regardless of "[PATCH vN]")
---
 lib/PublicInbox/Feed.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index a0f901e..d34978c 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -345,7 +345,7 @@ sub add_topic {
 		my $mid = $header_obj->header('Message-ID');
 		$mid = mid_compress(mid_clean($mid));
 		$u = $enc_utf8->decode($u);
-		push @$order, [ $mid, $ts, $u, $subj ];
+		push @$order, [ $mid, $ts, $u, $subj, $topic ];
 		return 1;
 	}
 	0; # old topic, continue going
@@ -357,8 +357,8 @@ sub dump_topics {
 	my $dst = '';
 	$dst .= "\n[No recent topics]" unless (scalar @$order);
 	while (defined(my $info = shift @$order)) {
-		my ($mid, $ts, $u, $subj) = @$info;
-		my $n = delete $subjs->{$subj};
+		my ($mid, $ts, $u, $subj, $topic) = @$info;
+		my $n = delete $subjs->{$topic};
 		$mid = PublicInbox::Hval->new($mid)->as_href;
 		$subj = PublicInbox::Hval->new($subj)->as_html;
 		$u = PublicInbox::Hval->new($u)->as_html;
-- 
EW


^ permalink raw reply related	[relevance 7%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-08-25  9:42  7% [PATCH] feed: fix "created" vs "updated" diff in topics Eric Wong

Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).