From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] feed: fix "created" vs "updated" diff in topics
Date: Tue, 25 Aug 2015 09:42:06 +0000 [thread overview]
Message-ID: <1440495726-31426-1-git-send-email-e@80x24.org> (raw)
This fixes a regression introduced in
commit 72c0f7c71ff28de9755dc4aee8b6ce6f0e4f2ed7
(feed: merge subjects regardless of "[PATCH vN]")
---
lib/PublicInbox/Feed.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index a0f901e..d34978c 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -345,7 +345,7 @@ sub add_topic {
my $mid = $header_obj->header('Message-ID');
$mid = mid_compress(mid_clean($mid));
$u = $enc_utf8->decode($u);
- push @$order, [ $mid, $ts, $u, $subj ];
+ push @$order, [ $mid, $ts, $u, $subj, $topic ];
return 1;
}
0; # old topic, continue going
@@ -357,8 +357,8 @@ sub dump_topics {
my $dst = '';
$dst .= "\n[No recent topics]" unless (scalar @$order);
while (defined(my $info = shift @$order)) {
- my ($mid, $ts, $u, $subj) = @$info;
- my $n = delete $subjs->{$subj};
+ my ($mid, $ts, $u, $subj, $topic) = @$info;
+ my $n = delete $subjs->{$topic};
$mid = PublicInbox::Hval->new($mid)->as_href;
$subj = PublicInbox::Hval->new($subj)->as_html;
$u = PublicInbox::Hval->new($u)->as_html;
--
EW
reply other threads:[~2015-08-25 9:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440495726-31426-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).