* [PATCH 5/5] extsearchidx: no need to make InboxWritable
@ 2020-12-16 23:19 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2020-12-16 23:19 UTC (permalink / raw)
To: meta
extindex treats v1/v2 public inboxes as read-only, so there's
no need to scare people by using the InboxWritable package
now that ->git_dir_n is gone and we can use ->max_git_epoch
instead of ->git_dir_latest.
---
lib/PublicInbox/ExtSearchIdx.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 3764612c..c6fb398b 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -63,7 +63,6 @@ sub new {
sub attach_inbox {
my ($self, $ibx) = @_;
- $ibx = PublicInbox::InboxWritable->new($ibx);
my $key = $ibx->eidx_key;
if (!$ibx->over || !$ibx->mm) {
warn "W: skipping $key (unindexed)\n";
@@ -78,7 +77,6 @@ sub attach_inbox {
warn "W: `$ibx->{inboxdir}' canonicalized to `$ibxdir'\n";
$ibx->{inboxdir} = $ibxdir;
}
- $ibx = PublicInbox::InboxWritable->new($ibx);
$self->{ibx_map}->{$key} //= do {
push @{$self->{ibx_list}}, $ibx;
$ibx;
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2020-12-16 23:19 [PATCH 0/5] various indexing cleanups and quieting Eric Wong
2020-12-16 23:19 7% ` [PATCH 5/5] extsearchidx: no need to make InboxWritable Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).