From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 776691FA18 for ; Wed, 16 Dec 2020 23:19:07 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 5/5] extsearchidx: no need to make InboxWritable Date: Wed, 16 Dec 2020 23:19:06 +0000 Message-Id: <20201216231906.6356-6-e@80x24.org> In-Reply-To: <20201216231906.6356-1-e@80x24.org> References: <20201216231906.6356-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: extindex treats v1/v2 public inboxes as read-only, so there's no need to scare people by using the InboxWritable package now that ->git_dir_n is gone and we can use ->max_git_epoch instead of ->git_dir_latest. --- lib/PublicInbox/ExtSearchIdx.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index 3764612c..c6fb398b 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -63,7 +63,6 @@ sub new { sub attach_inbox { my ($self, $ibx) = @_; - $ibx = PublicInbox::InboxWritable->new($ibx); my $key = $ibx->eidx_key; if (!$ibx->over || !$ibx->mm) { warn "W: skipping $key (unindexed)\n"; @@ -78,7 +77,6 @@ sub attach_inbox { warn "W: `$ibx->{inboxdir}' canonicalized to `$ibxdir'\n"; $ibx->{inboxdir} = $ibxdir; } - $ibx = PublicInbox::InboxWritable->new($ibx); $self->{ibx_map}->{$key} //= do { push @{$self->{ibx_list}}, $ibx; $ibx;