* [PATCH 1/5] extindex: show OID on bad blob failure
2021-10-13 7:00 5% [PATCH 0/5] warnings and such Eric Wong
@ 2021-10-13 7:00 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-10-13 7:00 UTC (permalink / raw)
To: meta
AFAIK I've never hit these messages, but I might be glad
if I ever do.
---
lib/PublicInbox/ExtSearchIdx.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 40489eab4c66..ddb16241e23d 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -595,11 +595,11 @@ sub _reindex_oid { # git->cat_async callback
my $oidbin = pack('H*', $expect_oid);
my $remain = _unref_doc($sync, $docid, undef, undef, $oidbin);
if ($remain == 0) {
- warn "W: #$docid gone or corrupted\n";
+ warn "W: #$docid ($oid) gone or corrupt\n";
} elsif (my $next_oid = $req->{xr3r}->[++$req->{ix}]->[2]) {
$self->git->cat_async($next_oid, \&_reindex_oid, $req);
} else {
- warn "BUG: #$docid gone (UNEXPECTED)\n";
+ warn "BUG: #$docid ($oid) gone (UNEXPECTED)\n";
}
return;
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/5] warnings and such
@ 2021-10-13 7:00 5% Eric Wong
2021-10-13 7:00 7% ` [PATCH 1/5] extindex: show OID on bad blob failure Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-10-13 7:00 UTC (permalink / raw)
To: meta
Patches 1-4/5 are all things which will probably make
more fsck-type things nicer across different CLI tools.
5/5 was something I noticed while working on 2a3c8d7a2c40
(daemon: unconditionally close Xapian shards on cleanup, 2021-10-12)
Eric Wong (5):
extindex: show OID on bad blob failure
lei: use standard warn() in more places
treewide: use warn() or carp() instead of env->{psgi.errors}
extindex: set {current_info} in eidxq processing
www: preload: load ExtSearch via ->ALL
lib/PublicInbox/ExtSearchIdx.pm | 9 +++---
lib/PublicInbox/Fetch.pm | 2 +-
lib/PublicInbox/GitHTTPBackend.pm | 39 ++++++--------------------
lib/PublicInbox/GzipFilter.pm | 3 +-
lib/PublicInbox/HTTP.pm | 16 ++++-------
lib/PublicInbox/LEI.pm | 18 ++++++++----
lib/PublicInbox/LeiBlob.pm | 3 +-
lib/PublicInbox/LeiConvert.pm | 2 +-
lib/PublicInbox/LeiForgetExternal.pm | 5 ++--
lib/PublicInbox/LeiImport.pm | 7 ++---
lib/PublicInbox/LeiImportKw.pm | 2 +-
lib/PublicInbox/LeiInput.pm | 4 +--
lib/PublicInbox/LeiMailSync.pm | 4 +--
lib/PublicInbox/LeiMirror.pm | 8 +++---
lib/PublicInbox/LeiP2q.pm | 2 +-
lib/PublicInbox/LeiRediff.pm | 3 +-
lib/PublicInbox/LeiRemote.pm | 2 +-
lib/PublicInbox/LeiViewText.pm | 2 +-
lib/PublicInbox/LeiXSearch.pm | 42 +++++++++++++++-------------
lib/PublicInbox/Qspawn.pm | 13 +++------
lib/PublicInbox/SearchView.pm | 7 ++---
lib/PublicInbox/Unsubscribe.pm | 5 +---
lib/PublicInbox/ViewVCS.pm | 6 ++--
lib/PublicInbox/WWW.pm | 1 +
lib/PublicInbox/WwwAltId.pm | 3 +-
lib/PublicInbox/WwwHighlight.pm | 2 +-
26 files changed, 89 insertions(+), 121 deletions(-)
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-10-13 7:00 5% [PATCH 0/5] warnings and such Eric Wong
2021-10-13 7:00 7% ` [PATCH 1/5] extindex: show OID on bad blob failure Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).