user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/5] extindex: show OID on bad blob failure
Date: Wed, 13 Oct 2021 07:00:34 +0000	[thread overview]
Message-ID: <20211013070038.6414-2-e@80x24.org> (raw)
In-Reply-To: <20211013070038.6414-1-e@80x24.org>

AFAIK I've never hit these messages, but I might be glad
if I ever do.
---
 lib/PublicInbox/ExtSearchIdx.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 40489eab4c66..ddb16241e23d 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -595,11 +595,11 @@ sub _reindex_oid { # git->cat_async callback
 		my $oidbin = pack('H*', $expect_oid);
 		my $remain = _unref_doc($sync, $docid, undef, undef, $oidbin);
 		if ($remain == 0) {
-			warn "W: #$docid gone or corrupted\n";
+			warn "W: #$docid ($oid) gone or corrupt\n";
 		} elsif (my $next_oid = $req->{xr3r}->[++$req->{ix}]->[2]) {
 			$self->git->cat_async($next_oid, \&_reindex_oid, $req);
 		} else {
-			warn "BUG: #$docid gone (UNEXPECTED)\n";
+			warn "BUG: #$docid ($oid) gone (UNEXPECTED)\n";
 		}
 		return;
 	}

  reply	other threads:[~2021-10-13  7:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13  7:00 [PATCH 0/5] warnings and such Eric Wong
2021-10-13  7:00 ` Eric Wong [this message]
2021-10-13  7:00 ` [PATCH 2/5] lei: use standard warn() in more places Eric Wong
2021-10-13  7:00 ` [PATCH 3/5] treewide: use warn() or carp() instead of env->{psgi.errors} Eric Wong
2021-10-13  7:00 ` [PATCH 4/5] extindex: set {current_info} in eidxq processing Eric Wong
2021-10-13  7:00 ` [PATCH 5/5] www: preload: load ExtSearch via ->ALL Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211013070038.6414-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH 1/5] extindex: show OID on bad blob failure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).