* [PATCH 1/4] content_id: workaround quote handling change in Email::* modules
2018-05-11 19:20 6% [PATCH 0/4] test fixes for latest CPAN modules Eric Wong
@ 2018-05-11 19:20 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2018-05-11 19:20 UTC (permalink / raw)
To: meta; +Cc: Konstantin Ryabitsev
I'm not entirely sure where the behavior change lies, but
it seems to be in some of the latest CPAN versions of these
modules. In any case, this only affects the test setup and
not actual behavior.
cf. https://public-inbox.org/meta/2a2bf0e1-fd1f-f8bf-95bc-dac47906ef43@linuxfoundation.org/
---
t/content_id.t | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/content_id.t b/t/content_id.t
index 01ce65e..990eabe 100644
--- a/t/content_id.t
+++ b/t/content_id.t
@@ -23,11 +23,11 @@ my $reload = content_id(Email::MIME->new($mime->as_string));
is($orig, $reload, 'content_id matches after serialization');
foreach my $h (qw(From To Cc)) {
- my $n = '"Quoted N\'Ame" <foo@EXAMPLE.com>';
- $mime->header_str_set($h, "$n");
+ my $n = q("Quoted N'Ame" <foo@EXAMPLE.com>);
+ $mime->header_set($h, "$n");
my $q = content_id($mime);
- is($n, $mime->header($h), "content_id does not mutate $h:");
- $mime->header_str_set($h, 'Quoted N\'Ame <foo@example.com>');
+ is($mime->header($h), $n, "content_id does not mutate $h:");
+ $mime->header_set($h, 'Quoted N\'Ame <foo@example.com>');
my $nq = content_id($mime);
is($nq, $q, "quotes ignored in $h:");
}
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] test fixes for latest CPAN modules
@ 2018-05-11 19:20 6% Eric Wong
2018-05-11 19:20 7% ` [PATCH 1/4] content_id: workaround quote handling change in Email::* modules Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2018-05-11 19:20 UTC (permalink / raw)
To: meta; +Cc: Konstantin Ryabitsev
A few test fixes for problems encountered by Konstantin on
CentOS 7 and some of the latest CPAN modules.
There's still locking problem in in t/v2mirror.t which I
have not reproduced, yet.
Eric Wong (4):
content_id: workaround quote handling change in Email::* modules
convert+compact: fix when running without ~/.public-inbox/config
t/v2mda: setup emergency Maildir for test
t/search: quiet warning from Encode.pm
script/public-inbox-compact | 10 ++++++----
script/public-inbox-convert | 10 ++++++----
t/content_id.t | 8 ++++----
t/convert-compact.t | 1 +
t/search.t | 2 +-
t/v2mda.t | 2 ++
6 files changed, 20 insertions(+), 13 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2018-05-11 19:20 6% [PATCH 0/4] test fixes for latest CPAN modules Eric Wong
2018-05-11 19:20 7% ` [PATCH 1/4] content_id: workaround quote handling change in Email::* modules Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).