user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: [PATCH 1/4] content_id: workaround quote handling change in Email::* modules
Date: Fri, 11 May 2018 19:20:15 +0000	[thread overview]
Message-ID: <20180511192018.6432-2-e@80x24.org> (raw)
In-Reply-To: <20180511192018.6432-1-e@80x24.org>

I'm not entirely sure where the behavior change lies, but
it seems to be in some of the latest CPAN versions of these
modules.  In any case, this only affects the test setup and
not actual behavior.

cf. https://public-inbox.org/meta/2a2bf0e1-fd1f-f8bf-95bc-dac47906ef43@linuxfoundation.org/
---
 t/content_id.t | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/t/content_id.t b/t/content_id.t
index 01ce65e..990eabe 100644
--- a/t/content_id.t
+++ b/t/content_id.t
@@ -23,11 +23,11 @@ my $reload = content_id(Email::MIME->new($mime->as_string));
 is($orig, $reload, 'content_id matches after serialization');
 
 foreach my $h (qw(From To Cc)) {
-	my $n = '"Quoted N\'Ame" <foo@EXAMPLE.com>';
-	$mime->header_str_set($h, "$n");
+	my $n = q("Quoted N'Ame" <foo@EXAMPLE.com>);
+	$mime->header_set($h, "$n");
 	my $q = content_id($mime);
-	is($n, $mime->header($h), "content_id does not mutate $h:");
-	$mime->header_str_set($h, 'Quoted N\'Ame <foo@example.com>');
+	is($mime->header($h), $n, "content_id does not mutate $h:");
+	$mime->header_set($h, 'Quoted N\'Ame <foo@example.com>');
 	my $nq = content_id($mime);
 	is($nq, $q, "quotes ignored in $h:");
 }

  reply	other threads:[~2018-05-11 19:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11 19:20 [PATCH 0/4] test fixes for latest CPAN modules Eric Wong
2018-05-11 19:20 ` Eric Wong [this message]
2018-05-11 19:20 ` [PATCH 2/4] convert+compact: fix when running without ~/.public-inbox/config Eric Wong
2018-05-11 19:20 ` [PATCH 3/4] t/v2mda: setup emergency Maildir for test Eric Wong
2018-05-11 19:20 ` [PATCH 4/4] t/search: quiet warning from Encode.pm Eric Wong
2018-05-11 19:27 ` [PATCH 0/4] test fixes for latest CPAN modules Konstantin Ryabitsev
2018-05-11 19:38   ` Eric Wong
2018-05-11 19:50     ` Konstantin Ryabitsev
2018-05-16  5:12       ` Eric Wong
2018-05-23 21:51         ` Konstantin Ryabitsev
2018-05-24  8:41           ` Eric Wong
2018-05-24 15:15             ` Konstantin Ryabitsev
2018-05-30 11:57               ` Eric Wong
2018-05-30 15:28                 ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180511192018.6432-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).