* [PATCH 3/7] xap_client: pass arguments to top-level xap_helper
2023-11-26 2:10 6% [PATCH 0/7] more I/O + process reliability and cleanups Eric Wong
@ 2023-11-26 2:11 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2023-11-26 2:11 UTC (permalink / raw)
To: meta
This ensures our tests actually test the -j0 and -j1 cases
properly.
---
lib/PublicInbox/XapClient.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/PublicInbox/XapClient.pm b/lib/PublicInbox/XapClient.pm
index 7737e30d..1f9ddccc 100644
--- a/lib/PublicInbox/XapClient.pm
+++ b/lib/PublicInbox/XapClient.pm
@@ -40,6 +40,7 @@ sub start_helper {
$cmd = [$^X, ($^W ? ('-w') : ()), "-M$cls", '-e',
$cls.'::start(@ARGV)', '--' ];
}
+ push @$cmd, @argv;
my $pid = spawn($cmd, $env, { 0 => $in });
my $self = bless { io => $sock, impl => $cls }, __PACKAGE__;
PublicInbox::IO::attach_pid($sock, $pid);
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] more I/O + process reliability and cleanups
@ 2023-11-26 2:10 6% Eric Wong
2023-11-26 2:11 7% ` [PATCH 3/7] xap_client: pass arguments to top-level xap_helper Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2023-11-26 2:10 UTC (permalink / raw)
To: meta
6/7 ought to fix another hang in t/lei-q-save.t when writing to
v2 outputs.
Much of this stuff will be relevant to code search since Xapian
searches will be moved to C++ (if available) to support features
which aren't usable from Perl bindings and allow more
predictable performance anyways.
Eric Wong (7):
xap_helper_cxx: do not copy xap_helper.h source
xap_client: attach PID to the IO object
xap_client: pass arguments to top-level xap_helper
xap_helper: allow PI_NO_CXX to disable C++ in more places
git: move rbuf handling to PublicInbox::IO
git: improve coupling with {sock} and {inflight} fields
drop redundant calls to DS->Reset
lib/PublicInbox/CodeSearchIdx.pm | 11 +--
lib/PublicInbox/Daemon.pm | 1 -
lib/PublicInbox/Gcf2Client.pm | 7 +-
lib/PublicInbox/Git.pm | 138 ++++++++++++-------------------
lib/PublicInbox/GitAsyncCat.pm | 2 +-
lib/PublicInbox/IO.pm | 70 ++++++++++++++--
lib/PublicInbox/TestCommon.pm | 2 +-
lib/PublicInbox/Watch.pm | 6 +-
lib/PublicInbox/XapClient.pm | 9 +-
lib/PublicInbox/XapHelperCxx.pm | 11 +--
lib/PublicInbox/Xapcmd.pm | 6 +-
t/xap_helper.t | 5 +-
12 files changed, 145 insertions(+), 123 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2023-11-26 2:10 6% [PATCH 0/7] more I/O + process reliability and cleanups Eric Wong
2023-11-26 2:11 7% ` [PATCH 3/7] xap_client: pass arguments to top-level xap_helper Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).