user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/7] xap_client: pass arguments to top-level xap_helper
Date: Sun, 26 Nov 2023 02:11:01 +0000	[thread overview]
Message-ID: <20231126021105.408573-4-e@80x24.org> (raw)
In-Reply-To: <20231126021105.408573-1-e@80x24.org>

This ensures our tests actually test the -j0 and -j1 cases
properly.
---
 lib/PublicInbox/XapClient.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/XapClient.pm b/lib/PublicInbox/XapClient.pm
index 7737e30d..1f9ddccc 100644
--- a/lib/PublicInbox/XapClient.pm
+++ b/lib/PublicInbox/XapClient.pm
@@ -40,6 +40,7 @@ sub start_helper {
 		$cmd = [$^X, ($^W ? ('-w') : ()), "-M$cls", '-e',
 			$cls.'::start(@ARGV)', '--' ];
 	}
+	push @$cmd, @argv;
 	my $pid = spawn($cmd, $env, { 0 => $in });
 	my $self = bless { io => $sock, impl => $cls }, __PACKAGE__;
 	PublicInbox::IO::attach_pid($sock, $pid);

  parent reply	other threads:[~2023-11-26  2:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-26  2:10 [PATCH 0/7] more I/O + process reliability and cleanups Eric Wong
2023-11-26  2:10 ` [PATCH 1/7] xap_helper_cxx: do not copy xap_helper.h source Eric Wong
2023-11-26  2:11 ` [PATCH 2/7] xap_client: attach PID to the IO object Eric Wong
2023-11-26  2:11 ` Eric Wong [this message]
2023-11-26  2:11 ` [PATCH 4/7] xap_helper: allow PI_NO_CXX to disable C++ in more places Eric Wong
2023-11-26  2:11 ` [PATCH 5/7] git: move rbuf handling to PublicInbox::IO Eric Wong
2023-11-26  2:11 ` [PATCH 6/7] git: improve coupling with {sock} and {inflight} fields Eric Wong
2023-11-26  2:11 ` [PATCH 7/7] drop redundant calls to DS->Reset Eric Wong
2023-11-26 21:08   ` [PATCH v2] " Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231126021105.408573-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).