* [PATCH 6/7] viewvcs: drop pointless variable assignment
2022-08-22 2:33 6% [PATCH 0/7] an even bigger git show than before Eric Wong
@ 2022-08-22 2:33 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-08-22 2:33 UTC (permalink / raw)
To: meta
Not needed since commit:
41f03a3bd4b13dfa (viewvcs: do not show final error message twice, 2019-01-27)
---
lib/PublicInbox/ViewVCS.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index d3fd152d..94656ad3 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -114,13 +114,12 @@ sub solve_result {
}
$log = do { local $/; <$log> };
- my $ref = ref($res);
my $l = PublicInbox::Linkify->new;
$log = '<pre>debug log:</pre><hr /><pre>' .
$l->to_html($log) . '</pre>';
$res or return html_page($ctx, 404, \$log);
- $ref eq 'ARRAY' or return html_page($ctx, 500, \$log);
+ ref($res) eq 'ARRAY' or return html_page($ctx, 500, \$log);
my ($git, $oid, $type, $size, $di) = @$res;
return show_other($ctx, $res, \$log, $fn) if $type ne 'blob';
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] an even bigger git show than before...
@ 2022-08-22 2:33 6% Eric Wong
2022-08-22 2:33 7% ` [PATCH 6/7] viewvcs: drop pointless variable assignment Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-08-22 2:33 UTC (permalink / raw)
To: meta
We can do things with patch emails, we might as well do some
things with git commits for folks with coderepos configured.
Eric Wong (7):
config: fix confusing space in ->repo_objs
xt/solver: improve diagnostics
www: /s/: 404 for unconfigured coderepos
qspawn: add type comments in a few places
qspawn: improve error reporting and handling
viewvcs: drop pointless variable assignment
viewvcs: start improving display of git commits
lib/PublicInbox/Config.pm | 2 +-
lib/PublicInbox/LeiBlob.pm | 4 +-
lib/PublicInbox/Qspawn.pm | 33 +++++-----
lib/PublicInbox/SolverGit.pm | 28 ++++-----
lib/PublicInbox/ViewVCS.pm | 116 +++++++++++++++++++++++++++++++----
lib/PublicInbox/WWW.pm | 3 +-
lib/PublicInbox/WwwStream.pm | 9 +++
t/qspawn.t | 14 ++++-
xt/solver.t | 7 +--
9 files changed, 162 insertions(+), 54 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-08-22 2:33 6% [PATCH 0/7] an even bigger git show than before Eric Wong
2022-08-22 2:33 7% ` [PATCH 6/7] viewvcs: drop pointless variable assignment Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).