* [PATCH 2/2] searchview: add link at bottom to reverse results
2019-06-15 20:23 5% [PATCH 0/2] support reversing search results Eric Wong
@ 2019-06-15 20:23 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2019-06-15 20:23 UTC (permalink / raw)
To: meta
I could not find a place to put the link the top without
making navigation too cluttered. Putting it at the bottom
of the page seems reasonable...
---
lib/PublicInbox/SearchView.pm | 4 +++-
t/psgi_v2.t | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index f0d803e..6f07279 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -232,7 +232,9 @@ sub search_nav_bot {
$rv .= qq{ <a\nhref="?$next"\nrel=next>next</a>} if $next;
$rv .= $join if $join;
$rv .= qq{<a\nhref="?$prev"\nrel=prev>prev</a>} if $prev;
- $rv .= '</pre>';
+
+ my $rev = $q->qs_html(o => $o < 0 ? 0 : -1);
+ $rv .= qq{ | <a\nhref="?$rev">reverse results</a></pre>};
}
sub sort_relevance {
diff --git a/t/psgi_v2.t b/t/psgi_v2.t
index 5c358cd..b8062de 100644
--- a/t/psgi_v2.t
+++ b/t/psgi_v2.t
@@ -155,7 +155,7 @@ test_psgi(sub { $www->call(@_) }, sub {
$res = $cb->(GET('/v2test/?q=m:a-mid@b&x=t'));
is($res->code, 200, 'success with threaded search');
my $raw = $res->content;
- ok($raw =~ s/\A.*>Results 1-3 of 3<//s, 'got all results');
+ ok($raw =~ s/\A.*>Results 1-3 of 3\b//s, 'got all results');
my @over = ($raw =~ m/\d{4}-\d+-\d+\s+\d+:\d+ (.+)$/gm);
is_deeply(\@over, [ '<a', '` <a', '` <a' ], 'threaded messages show up');
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] support reversing search results
@ 2019-06-15 20:23 5% Eric Wong
2019-06-15 20:23 7% ` [PATCH 2/2] searchview: add link at bottom to reverse results Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2019-06-15 20:23 UTC (permalink / raw)
To: meta
Occasionally it might be useful to show the oldest messages
matching a given search term (e.g. filename or an alternative
to "git blame").
Allowing a negative offset to reverse results seems to work
without increasing query parameter count (adding a new parameter
would be cache-unfriendly due to even less consistent ordering).
Reversing is now exposed at the bottom of the search results
page; since the top of the page is too cluttered.
Eric Wong (2):
searchview: support negative offsets to reverse ordering
searchview: add link at bottom to reverse results
lib/PublicInbox/SearchView.pm | 59 +++++++++++++++++++++++++----------
t/psgi_v2.t | 2 +-
2 files changed, 44 insertions(+), 17 deletions(-)
--
EW
^ permalink raw reply [relevance 5%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-06-15 20:23 5% [PATCH 0/2] support reversing search results Eric Wong
2019-06-15 20:23 7% ` [PATCH 2/2] searchview: add link at bottom to reverse results Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).