user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] searchview: add link at bottom to reverse results
Date: Sat, 15 Jun 2019 20:23:42 +0000	[thread overview]
Message-ID: <20190615202342.7730-3-e@80x24.org> (raw)
In-Reply-To: <20190615202342.7730-1-e@80x24.org>

I could not find a place to put the link the top without
making navigation too cluttered.  Putting it at the bottom
of the page seems reasonable...
---
 lib/PublicInbox/SearchView.pm | 4 +++-
 t/psgi_v2.t                   | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index f0d803e..6f07279 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -232,7 +232,9 @@ sub search_nav_bot {
 	$rv .= qq{  <a\nhref="?$next"\nrel=next>next</a>} if $next;
 	$rv .= $join if $join;
 	$rv .= qq{<a\nhref="?$prev"\nrel=prev>prev</a>} if $prev;
-	$rv .= '</pre>';
+
+	my $rev = $q->qs_html(o => $o < 0 ? 0 : -1);
+	$rv .= qq{ | <a\nhref="?$rev">reverse results</a></pre>};
 }
 
 sub sort_relevance {
diff --git a/t/psgi_v2.t b/t/psgi_v2.t
index 5c358cd..b8062de 100644
--- a/t/psgi_v2.t
+++ b/t/psgi_v2.t
@@ -155,7 +155,7 @@ test_psgi(sub { $www->call(@_) }, sub {
 	$res = $cb->(GET('/v2test/?q=m:a-mid@b&x=t'));
 	is($res->code, 200, 'success with threaded search');
 	my $raw = $res->content;
-	ok($raw =~ s/\A.*>Results 1-3 of 3<//s, 'got all results');
+	ok($raw =~ s/\A.*>Results 1-3 of 3\b//s, 'got all results');
 	my @over = ($raw =~ m/\d{4}-\d+-\d+\s+\d+:\d+ (.+)$/gm);
 	is_deeply(\@over, [ '<a', '` <a', '` <a' ], 'threaded messages show up');
 
-- 
EW


      parent reply	other threads:[~2019-06-15 20:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-15 20:23 [PATCH 0/2] support reversing search results Eric Wong
2019-06-15 20:23 ` [PATCH 1/2] searchview: support negative offsets to reverse ordering Eric Wong
2019-06-15 20:23 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190615202342.7730-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).