* [PATCH 7/9] lei_overview: clear redundant ovv_buf definition
2021-01-27 9:42 6% [PATCH 0/9] lei completion, some small updates Eric Wong
@ 2021-01-27 9:42 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-01-27 9:42 UTC (permalink / raw)
To: meta
Declaring "my $buf" inside that `if' branch was useless, so
we've been declaring it per-callback when {l2m} isn't in use.
---
lib/PublicInbox/LeiOverview.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm
index ea35871c..f9a28138 100644
--- a/lib/PublicInbox/LeiOverview.pm
+++ b/lib/PublicInbox/LeiOverview.pm
@@ -208,7 +208,6 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
$json = $pkg->new;
$json->utf8->canonical;
$json->ascii(1) if $lei->{opt}->{ascii};
- $lei->{ovv_buf} = \(my $buf = '');
}
my $l2m = $lei->{l2m} or $dedupe->prepare_dedupe;
if ($l2m && !$ibxish) { # remote https?:// mboxrd
^ permalink raw reply related [relevance 7%]
* [PATCH 0/9] lei completion, some small updates
@ 2021-01-27 9:42 6% Eric Wong
2021-01-27 9:42 7% ` [PATCH 7/9] lei_overview: clear redundant ovv_buf definition Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-01-27 9:42 UTC (permalink / raw)
To: meta
6/9 for bash completion brings us closer to very DRY
help + completion internals.
A couple of small other things while working on
something bigger...
Eric Wong (9):
eml: favor index() over regexp match
lei: drop "git" command forwarding
lei: fix comment regarding client payload
lei: ensure PWD is set correctly for path expansion
gcf2: rely on Perl 5.10 to avoid needless ++
lei: complete option switch args
lei_overview: clear redundant ovv_buf definition
v2writable: nproc: use sysconf() on Linux and FreeBSD
lei: dclose: fix typo
lib/PublicInbox/Eml.pm | 2 +-
lib/PublicInbox/Gcf2.pm | 9 +--
lib/PublicInbox/LEI.pm | 108 ++++++++++++++++++++-------------
lib/PublicInbox/LeiOverview.pm | 1 -
lib/PublicInbox/V2Writable.pm | 6 ++
t/lei.t | 46 ++++++++++++++
6 files changed, 123 insertions(+), 49 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-01-27 9:42 6% [PATCH 0/9] lei completion, some small updates Eric Wong
2021-01-27 9:42 7% ` [PATCH 7/9] lei_overview: clear redundant ovv_buf definition Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).