From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 7/9] lei_overview: clear redundant ovv_buf definition Date: Wed, 27 Jan 2021 03:42:28 -0600 [thread overview] Message-ID: <20210127094230.31174-8-e@80x24.org> (raw) In-Reply-To: <20210127094230.31174-1-e@80x24.org> Declaring "my $buf" inside that `if' branch was useless, so we've been declaring it per-callback when {l2m} isn't in use. --- lib/PublicInbox/LeiOverview.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm index ea35871c..f9a28138 100644 --- a/lib/PublicInbox/LeiOverview.pm +++ b/lib/PublicInbox/LeiOverview.pm @@ -208,7 +208,6 @@ sub ovv_each_smsg_cb { # runs in wq worker usually $json = $pkg->new; $json->utf8->canonical; $json->ascii(1) if $lei->{opt}->{ascii}; - $lei->{ovv_buf} = \(my $buf = ''); } my $l2m = $lei->{l2m} or $dedupe->prepare_dedupe; if ($l2m && !$ibxish) { # remote https?:// mboxrd
next prev parent reply other threads:[~2021-01-27 9:42 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-27 9:42 [PATCH 0/9] lei completion, some small updates Eric Wong 2021-01-27 9:42 ` [PATCH 1/9] eml: favor index() over regexp match Eric Wong 2021-01-27 9:42 ` [PATCH 2/9] lei: drop "git" command forwarding Eric Wong 2021-01-27 9:42 ` [PATCH 3/9] lei: fix comment regarding client payload Eric Wong 2021-01-27 9:42 ` [PATCH 4/9] lei: set PWD correctly for path expansion Eric Wong 2021-01-27 9:42 ` [PATCH 5/9] gcf2: rely on Perl 5.10 to avoid needless ++ Eric Wong 2021-01-27 9:42 ` [PATCH 6/9] lei: complete option switch args Eric Wong 2021-01-27 9:42 ` Eric Wong [this message] 2021-01-27 9:42 ` [PATCH 8/9] v2writable: nproc: use sysconf() on Linux and FreeBSD Eric Wong 2021-01-27 9:42 ` [PATCH 9/9] lei: dclose: fix typo Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210127094230.31174-8-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 7/9] lei_overview: clear redundant ovv_buf definition' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).