* [PATCH 3/7] isearch: mset_to_artnums: avoid unnecessary ops
2022-08-04 8:16 6% [PATCH 0/7] various op/allocation golfing Eric Wong
@ 2022-08-04 8:16 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2022-08-04 8:16 UTC (permalink / raw)
To: meta
We can use DBI's selectcol_arrayref directly (as we do in other
places) to avoid unnecessary arrays and ops on our end.
---
lib/PublicInbox/Isearch.pm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/Isearch.pm b/lib/PublicInbox/Isearch.pm
index df940e76..2b45e08e 100644
--- a/lib/PublicInbox/Isearch.pm
+++ b/lib/PublicInbox/Isearch.pm
@@ -69,12 +69,11 @@ sub mset_to_artnums {
$range = 'AND xnum >= ? AND xnum <= ?';
@r = @$r;
}
- my $rows = $self->{es}->over->dbh->
- selectall_arrayref(<<"", undef, $ibx_id, @$docids, @r);
+ return $self->{es}->over->dbh->
+ selectcol_arrayref(<<"", undef, $ibx_id, @$docids, @r);
SELECT xnum FROM xref3 WHERE ibx_id = ? AND docid IN ($qmarks) $range
ORDER BY xnum ASC
- return [ map { $_->[0] } @$rows ];
}
my $rows = $self->{es}->over->dbh->
^ permalink raw reply related [relevance 7%]
* [PATCH 0/7] various op/allocation golfing
@ 2022-08-04 8:16 6% Eric Wong
2022-08-04 8:16 7% ` [PATCH 3/7] isearch: mset_to_artnums: avoid unnecessary ops Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2022-08-04 8:16 UTC (permalink / raw)
To: meta
Nothing major, but some of these reduce Perl internal pad space,
which tends to add up across codebases with many cold paths.
Eric Wong (7):
http: coerce SERVER_PORT to integer
over: get_xref3: modify rows in-place
isearch: mset_to_artnums: avoid unnecessary ops
lei_overview: remove pointless map {} op
imap: ensure_slices_exist: drop needless map and array
feed: avoid unnecessary map loop in non-over path
view: avoid intermediate array when streaming thread
lib/PublicInbox/Feed.pm | 13 ++++++-------
lib/PublicInbox/HTTP.pm | 2 +-
lib/PublicInbox/IMAP.pm | 7 ++-----
lib/PublicInbox/Isearch.pm | 5 ++---
lib/PublicInbox/LeiOverview.pm | 2 +-
lib/PublicInbox/Over.pm | 8 ++++----
lib/PublicInbox/View.pm | 4 ++--
7 files changed, 18 insertions(+), 23 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2022-08-04 8:16 6% [PATCH 0/7] various op/allocation golfing Eric Wong
2022-08-04 8:16 7% ` [PATCH 3/7] isearch: mset_to_artnums: avoid unnecessary ops Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).