user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/7] isearch: mset_to_artnums: avoid unnecessary ops
Date: Thu,  4 Aug 2022 08:16:59 +0000	[thread overview]
Message-ID: <20220804081703.1410595-4-e@80x24.org> (raw)
In-Reply-To: <20220804081703.1410595-1-e@80x24.org>

We can use DBI's selectcol_arrayref directly (as we do in other
places) to avoid unnecessary arrays and ops on our end.
---
 lib/PublicInbox/Isearch.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Isearch.pm b/lib/PublicInbox/Isearch.pm
index df940e76..2b45e08e 100644
--- a/lib/PublicInbox/Isearch.pm
+++ b/lib/PublicInbox/Isearch.pm
@@ -69,12 +69,11 @@ sub mset_to_artnums {
 			$range = 'AND xnum >= ? AND xnum <= ?';
 			@r = @$r;
 		}
-		my $rows = $self->{es}->over->dbh->
-			selectall_arrayref(<<"", undef, $ibx_id, @$docids, @r);
+		return $self->{es}->over->dbh->
+			selectcol_arrayref(<<"", undef, $ibx_id, @$docids, @r);
 SELECT xnum FROM xref3 WHERE ibx_id = ? AND docid IN ($qmarks) $range
 ORDER BY xnum ASC
 
-		return [ map { $_->[0] } @$rows ];
 	}
 
 	my $rows = $self->{es}->over->dbh->

  parent reply	other threads:[~2022-08-04  8:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04  8:16 [PATCH 0/7] various op/allocation golfing Eric Wong
2022-08-04  8:16 ` [PATCH 1/7] http: coerce SERVER_PORT to integer Eric Wong
2022-08-04  8:16 ` [PATCH 2/7] over: get_xref3: modify rows in-place Eric Wong
2022-08-04  8:16 ` Eric Wong [this message]
2022-08-04  8:17 ` [PATCH 4/7] lei_overview: remove pointless map {} op Eric Wong
2022-08-04  8:17 ` [PATCH 5/7] imap: ensure_slices_exist: drop needless map and array Eric Wong
2022-08-04  8:17 ` [PATCH 6/7] feed: avoid unnecessary map loop in non-over path Eric Wong
2022-08-04  8:17 ` [PATCH 7/7] view: avoid intermediate array when streaming thread Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220804081703.1410595-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).