* [PATCH 3/3] import: set binmode before printing author names
@ 2016-04-09 9:14 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2016-04-09 9:14 UTC (permalink / raw)
To: meta
Author names may have wide characters in them, so avoid warnings
as git favors UTF-8 for names and fast-import even requires them
for commit messages
---
lib/PublicInbox/Import.pm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index e2156f1..4c7bbf1 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -162,11 +162,16 @@ sub add {
unless ($parent) {
print $w "reset $ref\n" or wfail;
}
+
+ # quiet down wide character warnings:
+ binmode $w, ':utf8' or die "binmode :utf8 failed: $!";
print $w "commit $ref\nmark :$commit\n",
"author $name <$email> $date\n",
"committer $self->{ident} ", now2822(), "\n",
"data ", (length($subject) + 1), "\n",
$subject, "\n\n" or wfail;
+ binmode $w, ':raw' or die "binmode :raw failed: $!";
+
if ($tip ne '') {
print $w 'from ', ($parent ? $parent : $tip), "\n" or wfail;
}
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-04-09 9:14 [PATCH 0/3] initial importer work Eric Wong
2016-04-09 9:14 7% ` [PATCH 3/3] import: set binmode before printing author names Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).