From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/3] import: set binmode before printing author names
Date: Sat, 9 Apr 2016 09:14:57 +0000 [thread overview]
Message-ID: <20160409091457.14741-4-e@80x24.org> (raw)
In-Reply-To: <20160409091457.14741-1-e@80x24.org>
Author names may have wide characters in them, so avoid warnings
as git favors UTF-8 for names and fast-import even requires them
for commit messages
---
lib/PublicInbox/Import.pm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index e2156f1..4c7bbf1 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -162,11 +162,16 @@ sub add {
unless ($parent) {
print $w "reset $ref\n" or wfail;
}
+
+ # quiet down wide character warnings:
+ binmode $w, ':utf8' or die "binmode :utf8 failed: $!";
print $w "commit $ref\nmark :$commit\n",
"author $name <$email> $date\n",
"committer $self->{ident} ", now2822(), "\n",
"data ", (length($subject) + 1), "\n",
$subject, "\n\n" or wfail;
+ binmode $w, ':raw' or die "binmode :raw failed: $!";
+
if ($tip ne '') {
print $w 'from ', ($parent ? $parent : $tip), "\n" or wfail;
}
--
EW
next prev parent reply other threads:[~2016-04-09 9:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 9:14 [PATCH 0/3] initial importer work Eric Wong
2016-04-09 9:14 ` [PATCH 1/3] git: add support for qx wrapper Eric Wong
2016-04-09 9:14 ` [PATCH 2/3] import: initial module + test case Eric Wong
2016-04-09 9:14 ` Eric Wong [this message]
2016-04-11 5:20 ` [PATCH 4/3] import: use bytes::length for true data length in bytes Eric Wong
2016-04-12 21:18 ` [PATCH 5/3] import: filter out [<>] from user names Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160409091457.14741-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).