From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/3] import: filter out [<>] from user names
Date: Tue, 12 Apr 2016 21:18:24 +0000 [thread overview]
Message-ID: <20160412211824.GA20034@dcvr.yhbt.net> (raw)
In-Reply-To: <20160411052049.GA26650@dcvr.yhbt.net>
It confuses the git ident parser and may not be a great
idea to fix in git since it could break interopability
with older versions.
---
lib/PublicInbox/Import.pm | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 5bae69d..7073c3d 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -139,6 +139,12 @@ sub add {
my $mid = mid_mime($mime);
my $path = mid2path($mid);
+ # git gets confused with:
+ # "'A U Thor <u@example.com>' via foo" <foo@example.com>
+ # ref:
+ # <CAD0k6qSUYANxbjjbE4jTW4EeVwOYgBD=bXkSu=akiYC_CB7Ffw@mail.gmail.com>
+ $name =~ s/<([^>]+)>/($1)/g;
+
my ($r, $w) = $self->gfi_start;
my $tip = $self->{tip};
if ($tip ne '') {
--
EW
prev parent reply other threads:[~2016-04-12 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 9:14 [PATCH 0/3] initial importer work Eric Wong
2016-04-09 9:14 ` [PATCH 1/3] git: add support for qx wrapper Eric Wong
2016-04-09 9:14 ` [PATCH 2/3] import: initial module + test case Eric Wong
2016-04-09 9:14 ` [PATCH 3/3] import: set binmode before printing author names Eric Wong
2016-04-11 5:20 ` [PATCH 4/3] import: use bytes::length for true data length in bytes Eric Wong
2016-04-12 21:18 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412211824.GA20034@dcvr.yhbt.net \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).