* [PATCH 4/4] extindex: better locations for {quit} checks
2021-10-17 9:52 6% [PATCH 0/4] extindex tweaks and small fixes Eric Wong
@ 2021-10-17 9:52 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2021-10-17 9:52 UTC (permalink / raw)
To: meta
Check for graceful termination at every message since it's
a fairly inexpensive check.
---
lib/PublicInbox/ExtSearchIdx.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index cb5256a2c562..f479cf9e1a3f 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -908,10 +908,9 @@ ibx_id = ? AND xnum >= ? AND xnum <= ?
for my $num (@$docids) {
$self->{oidx}->eidxq_add($num);
}
- return if $sync->{quit};
}
+ return if $sync->{quit};
}
- return if $sync->{quit};
next unless scalar keys %x3m;
$self->git->async_wait_all; # wait for reindex_unseen
@@ -936,6 +935,7 @@ BUG: (non-fatal) $ekey #$xnum $smsg->{blob} still matches (old exp: $exp)
for my $i (@$docids) {
_unref_doc($sync, $i, $ibx, $xnum, $bin);
}
+ return if $sync->{quit};
}
}
defined($hi) and ($hi < $max) and
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] extindex tweaks and small fixes
@ 2021-10-17 9:52 6% Eric Wong
2021-10-17 9:52 7% ` [PATCH 4/4] extindex: better locations for {quit} checks Eric Wong
0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2021-10-17 9:52 UTC (permalink / raw)
To: meta
Probably nothing of note, but some extra safety and
redundant work elimination.
Eric Wong (4):
extindex: use localtime to display lock time
extindex: retry sync_inbox before reindex
extindex: guard against false mismatch unrefs
extindex: better locations for {quit} checks
lib/PublicInbox/ExtSearchIdx.pm | 31 ++++++++++++++++++++++++-------
1 file changed, 24 insertions(+), 7 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-10-17 9:52 6% [PATCH 0/4] extindex tweaks and small fixes Eric Wong
2021-10-17 9:52 7% ` [PATCH 4/4] extindex: better locations for {quit} checks Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).