From: Eric Wong <e@80x24.org> To: meta@public-inbox.org Subject: [PATCH 4/4] extindex: better locations for {quit} checks Date: Sat, 16 Oct 2021 22:52:50 -1100 [thread overview] Message-ID: <20211017095250.22252-5-e@80x24.org> (raw) In-Reply-To: <20211017095250.22252-1-e@80x24.org> Check for graceful termination at every message since it's a fairly inexpensive check. --- lib/PublicInbox/ExtSearchIdx.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm index cb5256a2c562..f479cf9e1a3f 100644 --- a/lib/PublicInbox/ExtSearchIdx.pm +++ b/lib/PublicInbox/ExtSearchIdx.pm @@ -908,10 +908,9 @@ ibx_id = ? AND xnum >= ? AND xnum <= ? for my $num (@$docids) { $self->{oidx}->eidxq_add($num); } - return if $sync->{quit}; } + return if $sync->{quit}; } - return if $sync->{quit}; next unless scalar keys %x3m; $self->git->async_wait_all; # wait for reindex_unseen @@ -936,6 +935,7 @@ BUG: (non-fatal) $ekey #$xnum $smsg->{blob} still matches (old exp: $exp) for my $i (@$docids) { _unref_doc($sync, $i, $ibx, $xnum, $bin); } + return if $sync->{quit}; } } defined($hi) and ($hi < $max) and
prev parent reply other threads:[~2021-10-17 9:52 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-17 9:52 [PATCH 0/4] extindex tweaks and small fixes Eric Wong 2021-10-17 9:52 ` [PATCH 1/4] extindex: use localtime to display lock time Eric Wong 2021-10-17 9:52 ` [PATCH 2/4] extindex: retry sync_inbox before reindex Eric Wong 2021-10-17 9:52 ` [PATCH 3/4] extindex: guard against false mismatch unrefs Eric Wong 2021-10-17 9:52 ` Eric Wong [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://public-inbox.org/README * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211017095250.22252-5-e@80x24.org \ --to=e@80x24.org \ --cc=meta@public-inbox.org \ --subject='Re: [PATCH 4/4] extindex: better locations for {quit} checks' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/public-inbox.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).