user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 4/6] fetch: fix missing chdir arg for error reporting
Date: Tue, 26 Sep 2023 07:44:38 +0000	[thread overview]
Message-ID: <20230926074440.392023-5-e@80x24.org> (raw)
In-Reply-To: <20230926074440.392023-1-e@80x24.org>

We need to run `git config -l' in the epoch directory which
failed to get the proper config listing.  This went unnoticed
because it doesn't affect any known users and was only found
during code inspection for waitpid usage cleanups.
---
 lib/PublicInbox/Fetch.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Fetch.pm b/lib/PublicInbox/Fetch.pm
index f93eeebe..8f3a87e2 100644
--- a/lib/PublicInbox/Fetch.pm
+++ b/lib/PublicInbox/Fetch.pm
@@ -131,8 +131,9 @@ sub do_fetch { # main entry point
 				$epoch = $nr;
 			} else {
 				warn "W: $edir missing remote.*.url\n";
-				my $pid = spawn([qw(git config -l)], undef,
-					{ 1 => $lei->{2}, 2 => $lei->{2} });
+				my $o = { -C => $edir };
+				$o->{1} = $o->{2} = $lei->{2};
+				my $pid = spawn([qw(git config -l)], undef, $o);
 				waitpid($pid, 0);
 				$lei->child_error($?) if $?;
 			}

  parent reply	other threads:[~2023-09-26  7:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26  7:44 [PATCH 0/6] waitpid-related cleanups Eric Wong
2023-09-26  7:44 ` [PATCH 1/6] ds: awaitpid: Perl waitpid retries on EINTR automatically Eric Wong
2023-09-26  7:44 ` [PATCH 2/6] auto_reap: waitpid never returns undef Eric Wong
2023-09-26  7:44 ` [PATCH 3/6] lei_blob: use ProcessPipe to eliminate a waitpid call Eric Wong
2023-09-26  7:44 ` Eric Wong [this message]
2023-09-26  7:44 ` [PATCH 5/6] spamcheck/spamc: rely on ProcessPipe instead of waitpid Eric Wong
2023-09-26  7:44 ` [PATCH 6/6] spawn: add run_wait to simplify spawn+waitpid use Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926074440.392023-5-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).