From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/6] waitpid-related cleanups
Date: Tue, 26 Sep 2023 07:44:34 +0000 [thread overview]
Message-ID: <20230926074440.392023-1-e@80x24.org> (raw)
Mainly, much of our code was too noisy and guarding for waitpid
error cases which never happen.
Perl `waitpid' will always retry on EINTR (cf. perlipc(1)) and
it never returns `undef' on error, only -1. I don't understand
why Perl does it this way, all other syscalls return `undef' on
error, but Perl only documents -1 for errors and my
understanding of the Perl sources says it can't return `undef'.
So start working on reducing waitpid call sites...
Eric Wong (6):
ds: awaitpid: Perl waitpid retries on EINTR automatically
auto_reap: waitpid never returns undef
lei_blob: use ProcessPipe to eliminate a waitpid call
fetch: fix missing chdir arg for error reporting
spamcheck/spamc: rely on ProcessPipe instead of waitpid
spawn: add run_wait to simplify spawn+waitpid use
lib/PublicInbox/AutoReap.pm | 7 +++----
lib/PublicInbox/DS.pm | 9 +++------
lib/PublicInbox/Fetch.pm | 10 +++++-----
lib/PublicInbox/LEI.pm | 5 ++---
lib/PublicInbox/LeiBlob.pm | 19 +++++++------------
lib/PublicInbox/LeiMailDiff.pm | 6 ++----
lib/PublicInbox/LeiMirror.pm | 8 +++-----
lib/PublicInbox/LeiRediff.pm | 7 +++----
lib/PublicInbox/SearchIdx.pm | 6 ++----
lib/PublicInbox/Spamcheck/Spamc.pm | 11 ++++-------
lib/PublicInbox/Spawn.pm | 13 +++++++++----
lib/PublicInbox/TestCommon.pm | 6 +-----
12 files changed, 44 insertions(+), 63 deletions(-)
More deletions than insertions is good.
next reply other threads:[~2023-09-26 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 7:44 Eric Wong [this message]
2023-09-26 7:44 ` [PATCH 1/6] ds: awaitpid: Perl waitpid retries on EINTR automatically Eric Wong
2023-09-26 7:44 ` [PATCH 2/6] auto_reap: waitpid never returns undef Eric Wong
2023-09-26 7:44 ` [PATCH 3/6] lei_blob: use ProcessPipe to eliminate a waitpid call Eric Wong
2023-09-26 7:44 ` [PATCH 4/6] fetch: fix missing chdir arg for error reporting Eric Wong
2023-09-26 7:44 ` [PATCH 5/6] spamcheck/spamc: rely on ProcessPipe instead of waitpid Eric Wong
2023-09-26 7:44 ` [PATCH 6/6] spawn: add run_wait to simplify spawn+waitpid use Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926074440.392023-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).