user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
* [PATCH] extindex: guard against buggy unrefs
@ 2021-10-14  5:49 Eric Wong
  2021-10-14  6:06 ` [PATCH v2] " Eric Wong
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Wong @ 2021-10-14  5:49 UTC (permalink / raw)
  To: meta

I noticed some unref messages which shouldn't have been
happening, but they were.  Which is troubling.  So add
a guard around an unref path until we can get to the bottom
of this.
---
 lib/PublicInbox/ExtSearchIdx.pm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/PublicInbox/ExtSearchIdx.pm b/lib/PublicInbox/ExtSearchIdx.pm
index 750ced5c..363e5665 100644
--- a/lib/PublicInbox/ExtSearchIdx.pm
+++ b/lib/PublicInbox/ExtSearchIdx.pm
@@ -18,6 +18,7 @@ use strict;
 use v5.10.1;
 use parent qw(PublicInbox::ExtSearch PublicInbox::Lock);
 use Carp qw(croak carp);
+use Scalar::Util qw(blessed);
 use Sys::Hostname qw(hostname);
 use POSIX qw(strftime);
 use File::Glob qw(bsd_glob GLOB_NOSORT);
@@ -143,6 +144,14 @@ sub _unref_doc ($$$$$;$) {
 		$smsg = $docid;
 		$docid = $smsg->{num};
 	}
+	if (defined($oidbin) && defined($xnum) && blessed($ibx) $ibx->over) {
+		my $smsg = $ibx->over->get_art($xnum);
+		if ($smsg && pack('H*', $smsg->{blob}) eq $oidbin) {
+			carp("BUG: (non-fatal) ".$ibx->eidx_key.
+				" #$xnum $smsg->{blob} still valid");
+			return;
+		}
+	}
 	my $s = 'DELETE FROM xref3 WHERE oidbin = ?';
 	$s .= ' AND ibx_id = ?' if defined($ibx);
 	$s .= ' AND xnum = ?' if defined($xnum);

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-16  1:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-14  5:49 [PATCH] extindex: guard against buggy unrefs Eric Wong
2021-10-14  6:06 ` [PATCH v2] " Eric Wong
2021-10-14 21:09   ` Eric Wong
2021-10-16  1:48     ` [PATCH] extindex: avoid triggering a buggy unref Eric Wong

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).