user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/7] inbox: do not waste hash slot on httpbackend_limiter
Date: Wed, 22 Sep 2021 02:24:33 +0000	[thread overview]
Message-ID: <20210922022435.17835-6-e@80x24.org> (raw)
In-Reply-To: <20210922022435.17835-1-e@80x24.org>

A few dozen bytes saved here can add up when we have thousands
of inboxes.  It also makes Data::Dumper debug output a bit cleaner.
---
 lib/PublicInbox/Inbox.pm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index 6cd20ec0..20f8c884 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -126,11 +126,12 @@ sub version {
 
 sub git_epoch {
 	my ($self, $epoch) = @_; # v2-only, callers always supply $epoch
-	$self->{"$epoch.git"} ||= do {
+	$self->{"$epoch.git"} //= do {
 		my $git_dir = "$self->{inboxdir}/git/$epoch.git";
 		return unless -d $git_dir;
 		my $g = PublicInbox::Git->new($git_dir);
-		$g->{-httpbackend_limiter} = $self->{-httpbackend_limiter};
+		my $lim = $self->{-httpbackend_limiter};
+		$g->{-httpbackend_limiter} = $lim if $lim;
 		# caller must manually cleanup when done
 		$g;
 	};
@@ -138,11 +139,12 @@ sub git_epoch {
 
 sub git {
 	my ($self) = @_;
-	$self->{git} ||= do {
+	$self->{git} //= do {
 		my $git_dir = $self->{inboxdir};
 		$git_dir .= '/all.git' if $self->version == 2;
 		my $g = PublicInbox::Git->new($git_dir);
-		$g->{-httpbackend_limiter} = $self->{-httpbackend_limiter};
+		my $lim = $self->{-httpbackend_limiter};
+		$g->{-httpbackend_limiter} = $lim if $lim;
 		_cleanup_later($self);
 		$g;
 	};

  parent reply	other threads:[~2021-09-22  2:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  2:24 [PATCH 0/7] lei bugfixes and other fixes Eric Wong
2021-09-22  2:24 ` [PATCH 1/7] ipc: do not add "0" to $0 of solo workers Eric Wong
2021-09-22  2:24 ` [PATCH 2/7] treewide: fix %SIG localization, harder Eric Wong
2021-09-22  2:24 ` [PATCH 3/7] script/lei: describe purpose of sleep loop Eric Wong
2021-09-22  2:24 ` [PATCH 4/7] lei: dclose: do not close unnecessarily Eric Wong
2021-09-22  2:24 ` Eric Wong [this message]
2021-09-22  2:24 ` [PATCH 6/7] lei up: avoid excessively parallel --all Eric Wong
2021-09-22  2:24 ` [PATCH 7/7] lei: drop redundant WQ EOF callbacks Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210922022435.17835-6-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    --subject='Re: [PATCH 5/7] inbox: do not waste hash slot on httpbackend_limiter' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).