user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <>
Subject: [PATCH 4/7] lei: dclose: do not close unnecessarily
Date: Wed, 22 Sep 2021 02:24:32 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

The bit about reap_compress is no longer true since
LeiXSearch->query_done triggers it, instead.  I only noticed
this while working on "lei up".
 lib/PublicInbox/ | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/PublicInbox/ b/lib/PublicInbox/
index 29293e6c..a1cab55a 100644
--- a/lib/PublicInbox/
+++ b/lib/PublicInbox/
@@ -1110,7 +1110,6 @@ sub dclose {
 	my ($self) = @_;
 	delete $self->{-progress};
 	_drop_wq($self) if $self->{failed};
-	close(delete $self->{1}) if $self->{1}; # may reap_compress
 	$self->close if $self->{-event_init_done}; # PublicInbox::DS::close

  parent reply	other threads:[~2021-09-22  2:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  2:24 [PATCH 0/7] lei bugfixes and other fixes Eric Wong
2021-09-22  2:24 ` [PATCH 1/7] ipc: do not add "0" to $0 of solo workers Eric Wong
2021-09-22  2:24 ` [PATCH 2/7] treewide: fix %SIG localization, harder Eric Wong
2021-09-22  2:24 ` [PATCH 3/7] script/lei: describe purpose of sleep loop Eric Wong
2021-09-22  2:24 ` Eric Wong [this message]
2021-09-22  2:24 ` [PATCH 5/7] inbox: do not waste hash slot on httpbackend_limiter Eric Wong
2021-09-22  2:24 ` [PATCH 6/7] lei up: avoid excessively parallel --all Eric Wong
2021-09-22  2:24 ` [PATCH 7/7] lei: drop redundant WQ EOF callbacks Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).