user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] mbox: handle empty subjects after dropping "Re:" prefix
@ 2020-01-25  2:47 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2020-01-25  2:47 UTC (permalink / raw)
  To: meta

We can't pass empty strings to `to_filename' without
triggering warnings, and `to_filename' on an empty string
makes no sense.
---
 lib/PublicInbox/Mbox.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Mbox.pm b/lib/PublicInbox/Mbox.pm
index 1f9ac6ec..cf93e7db 100644
--- a/lib/PublicInbox/Mbox.pm
+++ b/lib/PublicInbox/Mbox.pm
@@ -24,11 +24,10 @@ sub subject_fn ($) {
 	# no need for full Email::MIME, here
 	if ($fn =~ /=\?/) {
 		eval { $fn = Encode::decode('MIME-Header', $fn) };
-		$fn = 'no-subject' if $@;
+		return 'no-subject' if $@;
 	}
 	$fn =~ s/^re:\s+//i;
-	$fn = to_filename($fn);
-	$fn eq '' ? 'no-subject' : $fn;
+	$fn eq '' ? 'no-subject' : to_filename($fn);
 }
 
 sub mb_stream {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-25  2:47 [PATCH] mbox: handle empty subjects after dropping "Re:" prefix Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.io/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git