From: Eric Wong <e@80x24.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: meta@public-inbox.org
Subject: Re: [PATCH 12/14] mda: support multiple List-ID matches
Date: Wed, 30 Oct 2019 21:32:52 +0000 [thread overview]
Message-ID: <20191030213252.GA46809@dcvr> (raw)
In-Reply-To: <874kzssq2o.fsf@x220.int.ebiederm.org>
"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> Eric Wong <e@80x24.org> writes:
>
> > While it's not RFC2919-conformant, mail software can
> > theoretically set multiple List-ID headers. Deliver to all
> > inboxes which match a given List-ID since that's likely the
> > intended.
>
> There is a todo line you can kill, noted below.
Done and pushed
> There should probably be a warning about List-ID's you can't
> look up.
>
> In case of misconfiguration or you subscribe to an extra mail-box and
> have not yet configured the List-ID for the list. I don't know how to
> find the List-ID ahead of time so it seems inevitiable that there will
> be a couple messages with an uncofigured List-ID.
I'm not so sure about that... We don't warn on existing cases
involving ORIGINAL_RECIPIENT/To/Cc. Instead, it goes to
~/.public-inbox/emergency/ (or whatever PI_EMERGENCY is set to).
> If you are not receiving from a mailling list you might get spam or
> other unsolicited email from someone's list server. Knowing the List-ID
> of that email is probably also useful. Knowing that this kind of
> non-sense exists guarantees that there will be email whose List-ID won't
> be configured.
Given we already toss undeliverables into an emergency/ Maildir;
I don't think training users to look for warnings in noisy (and
potentially access-limited) mail logs is necessary.
> > Cc: Eric W. Biederman <ebiederm@xmission.com>
> > Link: https://public-inbox.org/meta/87pniltscf.fsf@x220.int.ebiederm.org/
> > ---
> > diff --git a/lib/PublicInbox/MDA.pm b/lib/PublicInbox/MDA.pm
> > index ce2c870f..933d82a8 100644
> > --- a/lib/PublicInbox/MDA.pm
> > +++ b/lib/PublicInbox/MDA.pm
> > @@ -84,18 +84,25 @@ sub set_list_headers {
> > }
> >
> > # TODO: deal with multiple List-ID headers?
> ^^^^^^^^^^^^^^^^^^------ You can kill this line now.
Yup. I also have lots of TODO comments throughout which
need to be updated/removed :x
next prev parent reply other threads:[~2019-10-30 21:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 10:45 [PATCH 00/14] learn: sync w/ -mda changes and add manpage Eric Wong
2019-10-28 10:45 ` [PATCH 01/14] learn: support multiple To/Cc headers Eric Wong
2019-10-28 10:45 ` [PATCH 02/14] learn: only map recipient list on "ham" or "rm" Eric Wong
2019-10-28 10:45 ` [PATCH 03/14] learn: update usage statement Eric Wong
2019-10-28 10:45 ` [PATCH 04/14] learn: GIT_COMMITTER_<NAME|EMAIL> may be "" or "0" Eric Wong
2019-10-28 10:45 ` [PATCH 05/14] learn: hoist out remove_or_add subroutine Eric Wong
2019-10-28 10:45 ` [PATCH 06/14] mda: hoist out List-ID handling and reuse in -learn Eric Wong
2019-10-28 10:45 ` [PATCH 07/14] filter/base: remove MAX_MID_SIZE constant Eric Wong
2019-10-28 10:45 ` [PATCH 08/14] mda: hoist out mda_filter_adjust Eric Wong
2019-10-28 10:45 ` [PATCH 09/14] mda: skip MIME parsing if spam Eric Wong
2019-10-28 10:45 ` [PATCH 10/14] inboxwritable: add assert_usable_dir sub Eric Wong
2019-10-28 10:45 ` [PATCH 11/14] mda: prepare for multiple destinations Eric Wong
2019-10-28 10:45 ` [PATCH 12/14] mda: support multiple List-ID matches Eric Wong
2019-10-28 18:05 ` Eric W. Biederman
2019-10-30 21:32 ` Eric Wong [this message]
2019-10-28 10:45 ` [PATCH 13/14] learn: allow running without spamc Eric Wong
2019-10-28 10:45 ` [PATCH 14/14] doc: add public-inbox-learn(1) manpage Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030213252.GA46809@dcvr \
--to=e@80x24.org \
--cc=ebiederm@xmission.com \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).