From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 6557A1F4C0; Wed, 30 Oct 2019 21:32:53 +0000 (UTC) Date: Wed, 30 Oct 2019 21:32:52 +0000 From: Eric Wong To: "Eric W. Biederman" Cc: meta@public-inbox.org Subject: Re: [PATCH 12/14] mda: support multiple List-ID matches Message-ID: <20191030213252.GA46809@dcvr> References: <20191028104528.10140-1-e@80x24.org> <20191028104528.10140-13-e@80x24.org> <874kzssq2o.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <874kzssq2o.fsf@x220.int.ebiederm.org> List-Id: "Eric W. Biederman" wrote: > Eric Wong writes: > > > While it's not RFC2919-conformant, mail software can > > theoretically set multiple List-ID headers. Deliver to all > > inboxes which match a given List-ID since that's likely the > > intended. > > There is a todo line you can kill, noted below. Done and pushed > There should probably be a warning about List-ID's you can't > look up. > > In case of misconfiguration or you subscribe to an extra mail-box and > have not yet configured the List-ID for the list. I don't know how to > find the List-ID ahead of time so it seems inevitiable that there will > be a couple messages with an uncofigured List-ID. I'm not so sure about that... We don't warn on existing cases involving ORIGINAL_RECIPIENT/To/Cc. Instead, it goes to ~/.public-inbox/emergency/ (or whatever PI_EMERGENCY is set to). > If you are not receiving from a mailling list you might get spam or > other unsolicited email from someone's list server. Knowing the List-ID > of that email is probably also useful. Knowing that this kind of > non-sense exists guarantees that there will be email whose List-ID won't > be configured. Given we already toss undeliverables into an emergency/ Maildir; I don't think training users to look for warnings in noisy (and potentially access-limited) mail logs is necessary. > > Cc: Eric W. Biederman > > Link: https://public-inbox.org/meta/87pniltscf.fsf@x220.int.ebiederm.org/ > > --- > > diff --git a/lib/PublicInbox/MDA.pm b/lib/PublicInbox/MDA.pm > > index ce2c870f..933d82a8 100644 > > --- a/lib/PublicInbox/MDA.pm > > +++ b/lib/PublicInbox/MDA.pm > > @@ -84,18 +84,25 @@ sub set_list_headers { > > } > > > > # TODO: deal with multiple List-ID headers? > ^^^^^^^^^^^^^^^^^^------ You can kill this line now. Yup. I also have lots of TODO comments throughout which need to be updated/removed :x