From: Alyssa Ross <hi@alyssa.is>
To: meta@public-inbox.org
Cc: Alyssa Ross <hi@alyssa.is>
Subject: [PATCH] t/spawn: fix with unusual env locations
Date: Sun, 15 Sep 2019 13:48:20 +0000 [thread overview]
Message-ID: <20190915134819.1406-1-hi@alyssa.is> (raw)
The call to spawn clears the environment, including PATH. This means
that an env in a non-default location wouldn't be found, while all the
other tests work because they use PATH. We can fix this by looking up
which PATH to use beforehand.
I ran into this when packaging public-inbox for Nixpkgs. We build in
a chroot, and in this case the env I wanted to use was at
/nix/store/7rmjki86923bw1inx0czpp4wgy0kk687-coreutils-8.31/bin/env.
---
t/spawn.t | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/spawn.t b/t/spawn.t
index aba1a26..5549ca8 100644
--- a/t/spawn.t
+++ b/t/spawn.t
@@ -41,7 +41,8 @@ use PublicInbox::Spawn qw(which spawn popen_rd);
{
my ($r, $w);
pipe $r, $w or die "pipe failed: $!";
- my $pid = spawn(['env'], {}, { -env => 1, 1 => fileno($w) });
+ my $env = which('env');
+ my $pid = spawn([$env], {}, { -env => 1, 1 => fileno($w) });
close $w or die "close pipe[1] failed: $!";
ok(!defined(<$r>), 'read stdout of spawned from pipe');
is(waitpid($pid, 0), $pid, 'waitpid succeeds on spawned process');
--
2.22.1
next reply other threads:[~2019-09-15 13:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-15 13:48 Alyssa Ross [this message]
2019-09-15 18:55 ` [PATCH] t/spawn: fix with unusual env locations Eric Wong
2019-09-24 1:11 ` Alyssa Ross
2019-09-24 4:01 ` Eric Wong
2019-09-24 22:12 ` Test failures in build sandbox Alyssa Ross
2019-09-26 8:44 ` Eric Wong
2019-10-02 23:23 ` Alyssa Ross
2019-10-03 0:46 ` Alyssa Ross
2019-10-03 1:28 ` Eric Wong
2019-10-03 1:43 ` Alyssa Ross
2019-10-03 7:57 ` [PATCH] t/search: bail out on `git init --shared' failures Eric Wong
2019-10-03 10:15 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915134819.1406-1-hi@alyssa.is \
--to=hi@alyssa.is \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).