From: Eric Wong <firstname.lastname@example.org>
To: Alyssa Ross <email@example.com>
Subject: Re: [PATCH] t/spawn: fix with unusual env locations
Date: Tue, 24 Sep 2019 04:01:23 +0000 [thread overview]
Message-ID: <20190924040123.6jbtvpadnk6negox@whir> (raw)
Alyssa Ross <firstname.lastname@example.org> wrote:
> >> The call to spawn clears the environment, including PATH. This means
> >> that an env in a non-default location wouldn't be found, while all the
> >> other tests work because they use PATH. We can fix this by looking up
> >> which PATH to use beforehand.
> > Thanks for reporting this issue, but... is that it?
> > We also use spawn() for 'git', among other things...
> Yes, I can confirm that this was the only failing test case in my build.
Thanks for confirming, pushed my patch as
4b3e278d9c4e5d1f55c1781aa0a7c9f0453f3852 to master.
In my original reply, I missed the test was using the "-env"
option to clear %ENV. It's probably safe to drop the "-env"
option for spawn() to clear %ENV since we don't use it in real
> (It may be of note however that I did not have Xapian enabled. Trying
> to build with that caused a host of other failures that were beyond my
> ability to troubleshoot, so I decided to just give up on running the
> tests for now, since they seem very dependent on the environment and the
> environment inside our build sandboxes is so different from what
> public-inbox will have on a running system anyway.)
I don't know much about Nix, but I hope/expect public-inbox
tests to work on every reasonably modern Unix-like OS which
Perl5, git, and SQLite run on.
If you post logs of the failures you encountered, it would
improve the chances that somebody here (maybe not me) can
help fix them. Thanks.
next prev parent reply other threads:[~2019-09-24 4:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-15 13:48 [PATCH] t/spawn: fix with unusual env locations Alyssa Ross
2019-09-15 18:55 ` Eric Wong
2019-09-24 1:11 ` Alyssa Ross
2019-09-24 4:01 ` Eric Wong [this message]
2019-09-24 22:12 ` Test failures in build sandbox Alyssa Ross
2019-09-26 8:44 ` Eric Wong
2019-10-02 23:23 ` Alyssa Ross
2019-10-03 0:46 ` Alyssa Ross
2019-10-03 1:28 ` Eric Wong
2019-10-03 1:43 ` Alyssa Ross
2019-10-03 7:57 ` [PATCH] t/search: bail out on `git init --shared' failures Eric Wong
2019-10-03 10:15 ` Alyssa Ross
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).