user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] t/ds-leak: fix race
@ 2019-06-29  7:18 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-06-29  7:18 UTC (permalink / raw)
  To: meta

We need to ensure we run lsof on the sleep(1) process, and not
the fork of ourselves before execve(2).  This race applies when
we're using the default pure-Perl spawn() implementation.
---
 t/ds-leak.t | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/t/ds-leak.t b/t/ds-leak.t
index dd8446dc..34ffc125 100644
--- a/t/ds-leak.t
+++ b/t/ds-leak.t
@@ -15,9 +15,21 @@ if ('close-on-exec for epoll and kqueue') {
 
 	PublicInbox::DS->SetLoopTimeout(0);
 	PublicInbox::DS->SetPostLoopCallback(sub { 0 });
+
+	# make sure execve closes if we're using fork()
+	my ($r, $w);
+	pipe($r, $w) or die "pipe: $!";
+
 	PublicInbox::DS->AddTimer(0, sub { $pid = spawn([qw(sleep 10)]) });
 	PublicInbox::DS->EventLoop;
 	ok($pid, 'subprocess spawned');
+
+	# wait for execve, we need to ensure lsof sees sleep(1)
+	# and not the fork of this process:
+	close $w or die "close: $!";
+	my $l = <$r>;
+	is($l, undef, 'cloexec works and sleep(1) is running');
+
 	my @of = grep(/$evfd_re/, `lsof -p $pid 2>/dev/null`);
 	my $err = $?;
 	SKIP: {
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-29  7:18 [PATCH] t/ds-leak: fix race Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox