From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] t/common.perl: fix error message for git requirements
Date: Thu, 13 Jun 2019 01:53:18 +0000 [thread overview]
Message-ID: <20190613015318.4393-1-e@80x24.org> (raw)
And enable strict + warnings in the scope of t/common.perl, too.
---
t/common.perl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/t/common.perl b/t/common.perl
index e49a5965..5a898e32 100644
--- a/t/common.perl
+++ b/t/common.perl
@@ -3,6 +3,8 @@
use Fcntl qw(FD_CLOEXEC F_SETFD F_GETFD);
use POSIX qw(dup2);
+use strict;
+use warnings;
sub stream_to_string {
my ($res) = @_;
@@ -48,7 +50,7 @@ sub require_git ($;$) {
my $cur_int = ($cur_maj << 24) | ($cur_min << 16);
if ($cur_int < $req_int) {
return 0 if $maybe;
- plan skip_all => "git $req+ required, have $git_ver";
+ plan skip_all => "git $req+ required, have $cur_maj.$cur_min";
}
1;
}
--
EW
reply other threads:[~2019-06-13 1:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613015318.4393-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).