user/dev discussion of public-inbox itself
 help / color / Atom feed
* [PATCH] t/common.perl: fix error message for git requirements
@ 2019-06-13  1:53 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-06-13  1:53 UTC (permalink / raw)
  To: meta

And enable strict + warnings in the scope of t/common.perl, too.
---
 t/common.perl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/t/common.perl b/t/common.perl
index e49a5965..5a898e32 100644
--- a/t/common.perl
+++ b/t/common.perl
@@ -3,6 +3,8 @@
 
 use Fcntl qw(FD_CLOEXEC F_SETFD F_GETFD);
 use POSIX qw(dup2);
+use strict;
+use warnings;
 
 sub stream_to_string {
 	my ($res) = @_;
@@ -48,7 +50,7 @@ sub require_git ($;$) {
 	my $cur_int = ($cur_maj << 24) | ($cur_min << 16);
 	if ($cur_int < $req_int) {
 		return 0 if $maybe;
-		plan skip_all => "git $req+ required, have $git_ver";
+		plan skip_all => "git $req+ required, have $cur_maj.$cur_min";
 	}
 	1;
 }
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13  1:53 [PATCH] t/common.perl: fix error message for git requirements Eric Wong

user/dev discussion of public-inbox itself

Archives are clonable:
	git clone --mirror https://public-inbox.org/meta
	git clone --mirror http://czquwvybam4bgbro.onion/meta
	git clone --mirror http://hjrcffqmbrq6wope.onion/meta
	git clone --mirror http://ou63pmih66umazou.onion/meta

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
	nntp://ou63pmih66umazou.onion/inbox.comp.mail.public-inbox.meta
	nntp://czquwvybam4bgbro.onion/inbox.comp.mail.public-inbox.meta
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.mail.public-inbox.meta
	nntp://news.gmane.org/gmane.mail.public-inbox.general

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox