From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] viewdiff: escape HTML ampersand for renames
Date: Fri, 1 Feb 2019 07:50:29 +0000 [thread overview]
Message-ID: <20190201075030.23449-3-e@80x24.org> (raw)
In-Reply-To: <20190201075030.23449-1-e@80x24.org>
For URLs we generate, we need to escape '&' in query parameters
for correctness.
---
lib/PublicInbox/ViewDiff.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm
index 2074e12..fbdc5b9 100644
--- a/lib/PublicInbox/ViewDiff.pm
+++ b/lib/PublicInbox/ViewDiff.pm
@@ -133,8 +133,8 @@ sub flush_diff ($$$) {
Q => "?b=".uri_escape_utf8($pb, UNSAFE),
};
if ($pa ne $pb) {
- $dctx->{Q} .=
- "&a=".uri_escape_utf8($pa, UNSAFE);
+ $dctx->{Q} .= '&a='.
+ uri_escape_utf8($pa, UNSAFE);
}
anchor1($dst, $ctx, $linkify, $pb, $s) and next;
}
--
EW
next prev parent reply other threads:[~2019-02-01 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 7:50 [PATCH 0/3] viewvcs odds and ends Eric Wong
2019-02-01 7:50 ` [PATCH 1/3] viewvcs: allow '0' as a valid filename for blob downloads Eric Wong
2019-02-01 7:50 ` Eric Wong [this message]
2019-02-01 7:50 ` [PATCH 3/3] viewdiff: support renames and long paths in diffstat anchors Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201075030.23449-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).