user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] viewvcs: allow '0' as a valid filename for blob downloads
Date: Fri,  1 Feb 2019 07:50:28 +0000	[thread overview]
Message-ID: <20190201075030.23449-2-e@80x24.org> (raw)
In-Reply-To: <20190201075030.23449-1-e@80x24.org>

Only to be pedantic...
---
 lib/PublicInbox/ViewVCS.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index eecc51e..d67b5eb 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -110,7 +110,7 @@ sub solve_result {
 	}
 
 	my $binary = index($$blob, "\0") >= 0;
-	if ($fn) {
+	if (defined $fn) {
 		my $h = [ 'Content-Length', $size, 'Content-Type' ];
 		push(@$h, ($binary ? 'application/octet-stream' : 'text/plain'));
 		return delete($ctx->{-wcb})->([200, $h, [ $$blob ]]);
-- 
EW


  reply	other threads:[~2019-02-01  7:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01  7:50 [PATCH 0/3] viewvcs odds and ends Eric Wong
2019-02-01  7:50 ` Eric Wong [this message]
2019-02-01  7:50 ` [PATCH 2/3] viewdiff: escape HTML ampersand for renames Eric Wong
2019-02-01  7:50 ` [PATCH 3/3] viewdiff: support renames and long paths in diffstat anchors Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190201075030.23449-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).