Re: [PATCH 0/3] Making the search indexes optional

[Eric Wong <e@80x24.org>]

"Eric W. Biederman" <ebiederm@xmission.com> wrote:
> Here is the code to make the Xapian search indexes optional.
> 
> The first patch makes the term position database optional.
> The second patch makes anything in Xapian optional.
> Finally the last patch adds a config option.
> 
> At the end of the day it all looks simple and straight forward so I feel
> good about the code.  At the very least it looks like a good starting
> point.

Thanks for your work on this.  I have a few minor comments in
a separate message.  I expect you'll have tests and maybe
an option for public-inbox-index eventually?

> What this code does not do is make the Xapian code modules optional.  As
> that is more involved, and there is not much reward for that.  With a
> little cleverness in moving around code that is probably possible in a
> follow change.

Not required; but it could be nice-to-have for portability and
ease-of-installation (probably for older distros and
non-GNU/Linux platforms).

Off the top of my head, there's also some places in NNTP.pm
where it needlessly uses Search.pm wrappers instead of using
Over.pm interfaces directly.