From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0958E1F597; Wed, 18 Jul 2018 10:17:24 +0000 (UTC) Date: Wed, 18 Jul 2018 10:17:23 +0000 From: Eric Wong To: "Eric W. Biederman" Cc: meta@public-inbox.org Subject: Re: [PATCH 0/3] Making the search indexes optional Message-ID: <20180718101723.v4yomknxrhngrobq@whir> References: <87a7qpjve8.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87a7qpjve8.fsf@xmission.com> List-Id: "Eric W. Biederman" wrote: > Here is the code to make the Xapian search indexes optional. > > The first patch makes the term position database optional. > The second patch makes anything in Xapian optional. > Finally the last patch adds a config option. > > At the end of the day it all looks simple and straight forward so I feel > good about the code. At the very least it looks like a good starting > point. Thanks for your work on this. I have a few minor comments in a separate message. I expect you'll have tests and maybe an option for public-inbox-index eventually? > What this code does not do is make the Xapian code modules optional. As > that is more involved, and there is not much reward for that. With a > little cleverness in moving around code that is probably possible in a > follow change. Not required; but it could be nice-to-have for portability and ease-of-installation (probably for older distros and non-GNU/Linux platforms). Off the top of my head, there's also some places in NNTP.pm where it needlessly uses Search.pm wrappers instead of using Over.pm interfaces directly.