From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] filter/subjecttag: account for missing Subject: header
Date: Fri, 12 May 2017 18:49:32 +0000 [thread overview]
Message-ID: <20170512184932.20738-1-e@80x24.org> (raw)
This is a high indicator of spam (but out-of-scope for this
particular module) but sometimes it is not, and people
legitimately forget to set a Subject: header at all.
---
lib/PublicInbox/Filter/SubjectTag.pm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Filter/SubjectTag.pm b/lib/PublicInbox/Filter/SubjectTag.pm
index 1d28142..7735a94 100644
--- a/lib/PublicInbox/Filter/SubjectTag.pm
+++ b/lib/PublicInbox/Filter/SubjectTag.pm
@@ -19,8 +19,10 @@ sub new {
sub scrub {
my ($self, $mime) = @_;
my $subj = $mime->header('Subject');
- $subj =~ s/$self->{tag_re}/$1/; # $1 is "Re: "
- $mime->header_str_set('Subject', $subj);
+ if (defined $subj) {
+ $subj =~ s/$self->{tag_re}/$1/; # $1 is "Re: "
+ $mime->header_str_set('Subject', $subj);
+ }
$self->ACCEPT($mime);
}
--
EW
reply other threads:[~2017-05-12 18:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512184932.20738-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).