* [PATCH] filter/subjecttag: account for missing Subject: header
@ 2017-05-12 18:49 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-05-12 18:49 UTC (permalink / raw)
To: meta
This is a high indicator of spam (but out-of-scope for this
particular module) but sometimes it is not, and people
legitimately forget to set a Subject: header at all.
---
lib/PublicInbox/Filter/SubjectTag.pm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Filter/SubjectTag.pm b/lib/PublicInbox/Filter/SubjectTag.pm
index 1d28142..7735a94 100644
--- a/lib/PublicInbox/Filter/SubjectTag.pm
+++ b/lib/PublicInbox/Filter/SubjectTag.pm
@@ -19,8 +19,10 @@ sub new {
sub scrub {
my ($self, $mime) = @_;
my $subj = $mime->header('Subject');
- $subj =~ s/$self->{tag_re}/$1/; # $1 is "Re: "
- $mime->header_str_set('Subject', $subj);
+ if (defined $subj) {
+ $subj =~ s/$self->{tag_re}/$1/; # $1 is "Re: "
+ $mime->header_str_set('Subject', $subj);
+ }
$self->ACCEPT($mime);
}
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-05-12 18:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12 18:49 [PATCH] filter/subjecttag: account for missing Subject: header Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).