[PATCH 0/2] searchthread: minor cleanups and API change

[PATCH 0/2] searchthread: minor cleanups and API change

[Eric Wong]

Couldn't find more ways to speed things up, but it's looking
pretty good.  walk_thread could probably be moved into SearchThread.pm
(from View.pm), though

I also read enough of the Perl5 source code to learn
"scalar keys %hash" and "scalar values %hash"
follow the same code path and is optimized to not generate
an intermediate array :)

Eric Wong (2):
      searchthread: update comment about loop prevention
      searchthread: simplify API and remove needless OO

 lib/PublicInbox/SearchThread.pm | 39 ++++++++++++++-------------------------
 lib/PublicInbox/SearchView.pm   | 25 ++++++++++++-------------
 lib/PublicInbox/View.pm         | 19 ++++++++-----------
 t/thread-cycle.t                |  8 ++++----
 4 files changed, 38 insertions(+), 53 deletions(-)

[PATCH 1/2] searchthread: update comment about loop prevention

[Eric Wong]

It definitely is necessary to prevent looping with the
%seen hash.
---
 lib/PublicInbox/SearchThread.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/SearchThread.pm b/lib/PublicInbox/SearchThread.pm
index 601a84b..fafe7d7 100644
--- a/lib/PublicInbox/SearchThread.pm
+++ b/lib/PublicInbox/SearchThread.pm
@@ -129,7 +129,7 @@ sub add_child {
 
 sub has_descendent {
 	my ($self, $child) = @_;
-	my %seen; # loop prevention XXX may not be necessary
+	my %seen; # loop prevention
 	while ($child) {
 		return 1 if $self == $child || $seen{$child}++;
 		$child = $child->{parent};
-- 
EW