user/dev discussion of public-inbox itself
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] git-http-backend: do not drop connection on successful finish
Date: Thu, 12 May 2016 09:52:05 +0000	[thread overview]
Message-ID: <20160512095205.6139-3-e@80x24.org> (raw)
In-Reply-To: <20160512095205.6139-1-e@80x24.org>

We can maintain the client HTTP connection if the process exited
with failure as long as we terminated our own response properly.
---
 lib/PublicInbox/GitHTTPBackend.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 020b088..abb70df 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -259,10 +259,7 @@ sub serve_smart {
 		if (defined $pid) {
 			my $e = $pid == waitpid($pid, 0) ?
 				$? : "PID:$pid still running?";
-			if ($e) {
-				err($env, "git http-backend ($git_dir): $e");
-				drop_client($env);
-			}
+			err($env, "git http-backend ($git_dir): $e") if $e;
 		}
 		return unless $res;
 		my $dumb = serve_dumb($cgi, $git, $path);

      parent reply	other threads:[~2016-05-12  9:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12  9:52 [PATCH] import: normalize body by stripping trailing newlines Eric Wong
2016-05-12  9:52 ` [PATCH] import: fallback to email if '<>' exists in author name Eric Wong
2016-05-12  9:52 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160512095205.6139-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/public-inbox.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).